JAVA.IO.INJ.COMMAND : Command Injection (Java)

JavaScript is not currently enabled, but is required for full CodeSonar manual search and browse functionality.

If you are viewing this file in your hub's Web GUI, enable JavaScript in your browser: you will also need it for GUI functionality.

If you opened this file directly from disk, your browser may be directly suppressing JavaScript functionality: certain browsers perform this suppression on local files (but not files delivered by web servers) for security reasons.

If you access the manual through the hub's Web GUI, the functionality will not be suppressed because the hub is a web server.
Alternatively, your browser may allow you to explicitly disable the security setting that suppresses functionality. See the CodeSonar FAQ for more information.

CodeSonar^® 9.2p0

CONFIDENTIAL

CodeSecure Inc

JAVA.IO.INJ.COMMAND : Command Injection (Java)

Summary

Tainted data flows into a field annotated as @CommandTrusted, or into a command execution routine.

Checks for this class use the CodeSonar Java taint analysis. See Taint Tracking for CodeSonar Java Warning Classes for more information on this analysis, including lists of the methods that CodeSonar automatically recognizes as relevant and information about specifying additional methods that CodeSonar should recognize as taint sources, sinks, or sanitizers.

Use configuration parameter JAVA_ANALYSIS_ADVANCED_INJECTION to specify the level of checking to perform for this and other taint-related warning classes:

Properties

Example

import java.io.IOException;
import java.io.PrintWriter;

import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import com.juliasoft.julia.checkers.injection.SqlTrusted;
import com.juliasoft.julia.checkers.injection.Trusted;

@SuppressWarnings("serial")
public class BasicInjection extends HttpServlet {
  private @SqlTrusted Object sqlTrusted;
  private @Trusted Object trusted;
  public String a = "my friend";

  @Override
  protected final void doGet(HttpServletRequest request, HttpServletResponse response) throws IOException {
    processRequest(request, response);
  }

  private void test2(@SqlTrusted String s) {}

  private void test3(@Trusted String s) {}

  private void processRequest(HttpServletRequest request, HttpServletResponse response) throws IOException {
    response.setContentType("text/html;charset=UTF-8");

    String user = request.getParameter("user");              // The value of variable 'user' is obtained from user input
      out.println(user);                                     // and is therefore treated as tainted.

    try (PrintWriter out = response.getWriter()) {
      out.println("User : " + user); // Cross Site Scripting (Java) warning issued here
      out.println(user);             // Cross Site Scripting (Java) warning issued here
      out.println("hello");
      out.println("hello " + a);
    }

    if (user != null)
      test2(user);                   // SQL Injection (Java) warning issued here
    test2("User: " + user);          // SQL Injection (Java) warning issued here
    test2("hello");
    test2("hello " + a);
    test3(user);                     // Tainted @Trusted Value (Java) warning issued here
    test3("User: " + user);          // Tainted @Trusted Value (Java) warning issued here
    test3("hello");
    test3("hello " + a);
    sqlTrusted = user;               // SQL Injection (Java) warning issued here
    trusted = user;                  // Tainted @Trusted Value (Java) warning issued here
    sqlTrusted = "User: " + user;    // SQL Injection (Java) warning issued here
    trusted = "User: " + user;       // Tainted @Trusted Value (Java) warning issued here
    sqlTrusted = "hello";
    trusted = "hello";
    sqlTrusted = "hello " + a;
    trusted = "hello " + a;
  }
}

import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.net.InetAddress;
import java.net.URL;
import java.net.URLConnection;
import java.net.UnknownHostException;
import java.util.Base64;
import java.util.Scanner;

public class OtherInjectionExamples {

  public static void main(String[] args) {
      String input = getUserInput();

      addressInjectionExample(input);
      commandInjectionExample(input);
      pathInjectionExample(input);
      urlInjectionExample(input);
  }
    
  private static String getUserInput() {
      Scanner input = new Scanner(System.in);
      String s = input.nextLine();
      return s;
  }

  private static void addressInjectionExample(String input) {
      try {
        InetAddress ia = InetAddress.getByName(input); /* Tainted Network Address (Java) warning issued here
                                                        * only if JAVA_ANALYSIS_ADVANCED_INJECTION=Yes 
                                                        */ 
        System.out.println(ia.getHostName());    
      } catch (UnknownHostException e ) {
        System.out.println("Host not found:"+e.getMessage());   
      }
  }

  private static void commandInjectionExample(String input) {
      try {
        Runtime.getRuntime().exec(input);              /* Command Injection (Java) warning issued here
                                                        * only if JAVA_ANALYSIS_ADVANCED_INJECTION=Yes 
                                                        */ 
      } catch (IOException e) {
        System.out.println("Unable to exec command:"+e.getMessage());   
      }
  }

  private static void pathInjectionExample(String input) {
      File f= new File(input);                         /* Tainted Path (Java) warning issued here
                                                        * only if JAVA_ANALYSIS_ADVANCED_INJECTION=Yes 
                                                        */ 

      if(f.delete()) {  
          System.out.println(f.getName() + " deleted");  
      }  
  }
    
  private static void urlInjectionExample(String input) {
      try {
        URL url = new URL(input);                      /* Tainted URL (Java) warning issued here
                                                        * only if JAVA_ANALYSIS_ADVANCED_INJECTION=Yes 
                                                        */ 
        URLConnection urlcon=url.openConnection();  
        InputStream stream=urlcon.getInputStream();  
        byte[] bytes = stream.readAllBytes();
        String text = Base64.getEncoder().encodeToString(bytes);
        System.out.println(text);
      } catch (IOException e) {
        System.out.println("The URL is not valid: "+e.getMessage()); 
      }
  }
}

In this example, the programmer should avoid a direct flow of user input into sink methods. The solution is to use a sanitizing method or checking the user input in order to avoid possible unexpected behavior and ensure proper management of user input, so that it becomes harmless.

Resolution

Verify that a security error actually corresponds to unconstrained information flow from source locations into sink locations. If this is the case, add a sanitizing algorithm to clean data before it flows into sinks, or use safe statements to propagate data inside the program.

Relevant Configuration File Parameters

The following configuration file parameters affect checks for this warning class.