JAVA.CLASS.IOF.BAD : Inappropriate Instanceof (Java)

JavaScript is not currently enabled, but is required for full CodeSonar manual search and browse functionality.

If you are viewing this file in your hub's Web GUI, enable JavaScript in your browser: you will also need it for GUI functionality.

If you opened this file directly from disk, your browser may be directly suppressing JavaScript functionality: certain browsers perform this suppression on local files (but not files delivered by web servers) for security reasons.

If you access the manual through the hub's Web GUI, the functionality will not be suppressed because the hub is a web server.
Alternatively, your browser may allow you to explicitly disable the security setting that suppresses functionality. See the CodeSonar FAQ for more information.

CodeSonar^® 9.2p0

CONFIDENTIAL

CodeSecure Inc

JAVA.CLASS.IOF.BAD : Inappropriate Instanceof (Java)

Summary

Properties

Example

public class Foo {

  public String s
  
  @Override
  public boolean equals(Object obj) {
      if(obj != null)
          if (obj instanceof String) /* "Inappropriate Instanceof (Java)" warning issued here
                                      * - should only check for Foo or a class derived from Foo.
                                      */
              return s.equals(obj);
      return false;
  }
}

  @Override
  public boolean equals(Object obj) {
      if(obj != null)
          if (obj instanceof Foo)
              return s.equals(((Foo) obj).s);
    return false;
  }

Resolution

Check if the instanceof operator can be actually removed and that it is not the sign of an actual programming bug.

Relevant Configuration File Parameters

The following configuration file parameters affect checks for this warning class.