CSHARP.STRUCT.RC : Redundant Condition (C#)

JavaScript is not currently enabled, but is required for full CodeSonar manual search and browse functionality.

If you are viewing this file in your hub's Web GUI, enable JavaScript in your browser: you will also need it for GUI functionality.

If you opened this file directly from disk, your browser may be directly suppressing JavaScript functionality: certain browsers perform this suppression on local files (but not files delivered by web servers) for security reasons.

If you access the manual through the hub's Web GUI, the functionality will not be suppressed because the hub is a web server.
Alternatively, your browser may allow you to explicitly disable the security setting that suppresses functionality. See the CodeSonar FAQ for more information.

CodeSonar^® 9.2p0

CONFIDENTIAL

CodeSecure Inc

CSHARP.STRUCT.RC : Redundant Condition (C#)

Summary

This checker looks for tests that are useless since, for instance, their outcome drives control to the same execution path, regardless of the test itself. This happens for instance when the empty statement is used after a conditional because the programmer put a semicolon after the conditional. This checker also looks for tests that always have the same outcome (always true or always false).

Properties

Example

using System;

namespace DocumentationExamples
{

    public class UselessTest
    {
        public static void Main(string[] args)
        {
            if (args.Length < 2) ;  // Empty Branch Statement (C#) warning issued here 
            Environment.Exit(-1);
            Go(DateTime.Now.Millisecond % 4 == 0, DateTime.Now.Millisecond % 3 == 0);
            Test(17);
            object o = new object();
            if (o != new object())  // Redundant Condition (C#) warning issued here 
                Console.WriteLine("distinct");
        }
        public static void Go(bool b1, bool b2)
        {
            if (b1 = true)          // Redundant Condition (C#) warning issued here 
                Console.WriteLine("yes");
        }
        private static void Test(int i)
        {
            if (i == 17)            // Redundant Condition (C#) warning issued here 
                Console.WriteLine("17");
        }
    }
}

Resolution

Remove the check or complete a conditional with actual then or else branch, instead of an empty statement. Verify if the useless test is the sign of a more significant algorithmic problem.

Relevant Configuration File Parameters

The following configuration file parameters affect checks for this warning class.