CSHARP.MATH.ABSRAND : Abs on random (C#)

JavaScript is not currently enabled, but is required for full CodeSonar manual search and browse functionality.

If you are viewing this file in your hub's Web GUI, enable JavaScript in your browser: you will also need it for GUI functionality.

If you opened this file directly from disk, your browser may be directly suppressing JavaScript functionality: certain browsers perform this suppression on local files (but not files delivered by web servers) for security reasons.

If you access the manual through the hub's Web GUI, the functionality will not be suppressed because the hub is a web server.
Alternatively, your browser may allow you to explicitly disable the security setting that suppresses functionality. See the CodeSonar FAQ for more information.

CodeSonar^® 9.2p0

CONFIDENTIAL

CodeSecure Inc

CSHARP.MATH.ABSRAND : Abs on random (C#)

Summary

By computing the absolute value of a random integral number, one might actually yield a negative number, if Math.Abs() is used. For instance, Console.WriteLine(Math.Abs(Int32.MaxValue)) would actually print the negative value -2147483648. As a consequence, this might result in unexpected or erroneous computations.

Properties

Example

using System;

namespace DocumentationExamples
{

    public class AbsOfRandom
    {

        public static void Main(string[] args)
        {
            System.Random r = new System.Random();
            int i = r.Next();
            i = Math.Abs(i);     // Abs on random (C#) warning issued here 
            Console.WriteLine(i);
        }
    }

}

In this example, the programmer should check for the minimum integral value explicitly and behave accordingly, as in the following example.

System.Random r = new System.Random();
int i = r.Next();
if (i == Int32.MinValue)
    i = 0; // any non-negative value would do
else if (i < 0)
    i = -i;

Console.WriteLine(i);

Resolution

Check, explicitly, for the minimal integral value, before computing the absolute value. Otherwise, since Java 15, java.lang.Math.absExact and java.lang.StrictMath.absExact allows to compute the absolute values in a safe way, throwing ArithmeticException if the result overflows.

Relevant Configuration File Parameters

The following configuration file parameters affect checks for this warning class.